WebTorrent: Update libdatachannel #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullouisageneau
force-pushed
the
webtorrent-update-datachannel
branch
from
48193a8 to
3756c7c
Compare
paullouisageneau
force-pushed
the
webtorrent-update-datachannel
branch
4 times, most recently
from
a00ac5a to
3900dfc
Compare
|
the other PR is applying the peer_list fix and updating the submodule. Since it passed CI, that other PR is sufficient, right? or is this an additional update of the submodule? |
|
@arvidn My mistake, this other PR now applies only the peer_list fix. |
paullouisageneau
force-pushed
the
webtorrent-update-datachannel
branch
from
3900dfc to
9eda5e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #5188 +/- ##
==========================================
+ Coverage 65.30% 65.32% +0.03%
==========================================
Files 301 300 -1
Lines 32674 32687 +13
Branches 7135 7135
==========================================
+ Hits 21335 21352 +17
+ Misses 8752 8741 -11
- Partials 2587 2594 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #4123 and updates libdatachannel to fix multiple issues related to connection establishment time (especially when offering to Firefox) and transfer performance.