Call parent class callback_url when params[‘callback_url’] is nil

arunagw · Feb 6, 2017 · 7d066d1 · 7d066d1
1 parent 4b6122a
commit 7d066d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/omniauth/strategies/twitter.rb b/lib/omniauth/strategies/twitter.rb
@@ -61,8 +61,14 @@ def request_phase
         old_request_phase
       end
 
+      alias :old_callback_url :callback_url
+
       def callback_url
-        request.params['callback_url']
+        if request.params['callback_url']
+          request.params['callback_url']
+        else
+          old_callback_url
+        end
       end
 
       def callback_path

diff --git a/spec/omniauth/strategies/twitter_spec.rb b/spec/omniauth/strategies/twitter_spec.rb
@@ -160,10 +160,11 @@
           double('Session', :[] => {})
         end
         allow(subject).to receive(:old_request_phase) { :whatever }
+        allow(subject).to receive(:old_callback_url).and_return(:old_callback)
       end
 
       it 'callback_url should return nil' do
-        expect(subject.callback_url).to be_nil
+        expect(subject.callback_url).to eq :old_callback
       end
 
       it 'should return the default callback_path value' do