Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require ts type error not throw #270

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

JerrysShan
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (78d96c4) 91.53% compared to head (dda0099) 91.38%.

Files Patch % Lines
src/utils/compatible_require.ts 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   91.53%   91.38%   -0.15%     
==========================================
  Files          49       49              
  Lines        1193     1196       +3     
  Branches      216      218       +2     
==========================================
+ Hits         1092     1093       +1     
- Misses        101      103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrysShan JerrysShan requested review from noahziheng and Beace January 4, 2024 04:47
Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahziheng noahziheng merged commit c2ae5a7 into artusjs:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants