Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): add artus dir to package path resolver for pnpm #258

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

noahziheng
Copy link
Member

pnpm 可能出现依赖打平(flat)在 node_modules/.pnpm/node_modules

这种场景下,只使用扫描的 baseDir 加载包,可能找不到包路径

@noahziheng noahziheng self-assigned this Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (708889b) 91.68% compared to head (23ac385) 91.68%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          49       49           
  Lines        1203     1203           
  Branches      213      213           
=======================================
  Hits         1103     1103           
  Misses        100      100           
Impacted Files Coverage Δ
src/plugin/common.ts 97.61% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noahziheng noahziheng force-pushed the fix/package-path-resolver branch from 23ac385 to e5df9fa Compare July 20, 2023 13:26
@noahziheng noahziheng merged commit f5ab0e2 into master Jul 25, 2023
@noahziheng noahziheng deleted the fix/package-path-resolver branch July 25, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants