Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 减少代码的误解 #227

Merged
merged 4 commits into from
Jan 12, 2023
Merged

refactor: 减少代码的误解 #227

merged 4 commits into from
Jan 12, 2023

Conversation

DevXiaolan
Copy link
Contributor

No description provided.

noahziheng
noahziheng reviewed Jan 5, 2023
View reviewed changes
src/scanner/scan.ts Outdated Show resolved Hide resolved
hyj1991
hyj1991 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@hyj1991 hyj1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DevXiaolan DevXiaolan requested review from hyj1991 and noahziheng and removed request for hyj1991 January 6, 2023 13:37
noahziheng
noahziheng approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahziheng noahziheng self-assigned this Jan 12, 2023
@noahziheng noahziheng merged commit 1157c23 into artusjs:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyj1991 hyj1991 hyj1991 approved these changes

@noahziheng noahziheng noahziheng approved these changes

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees

@noahziheng noahziheng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DevXiaolan @fengmk2 @noahziheng @hyj1991