Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin): simplify impl #199

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

noahziheng
Copy link
Member

此 PR 简化了 Plugin 相关类的实现,对齐了统一的 Interface 命名和使用规则(*Type)

@noahziheng noahziheng force-pushed the refactor/simplify-plugin branch from 81aa6c8 to 10de9d4 Compare September 19, 2022 08:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 90.68% // Head: 91.77% // Increases project coverage by +1.08% 🎉

Coverage data is based on head (05325a9) compared to base (f71fa5a).
Patch coverage: 94.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   90.68%   91.77%   +1.08%     
==========================================
  Files          48       46       -2     
  Lines        1106     1094      -12     
  Branches      200      200              
==========================================
+ Hits         1003     1004       +1     
+ Misses        103       90      -13     
Impacted Files Coverage Δ
src/plugin/impl.ts 84.61% <90.00%> (+5.44%) ⬆️
src/application.ts 91.17% <100.00%> (+0.26%) ⬆️
src/loader/impl/plugin_config.ts 96.15% <100.00%> (ø)
src/plugin/common.ts 100.00% <100.00%> (ø)
src/plugin/factory.ts 90.90% <100.00%> (+25.28%) ⬆️
src/plugin/index.ts 100.00% <100.00%> (ø)
src/scanner/scan.ts 95.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noahziheng noahziheng requested a review from hyj1991 September 21, 2022 10:56
@noahziheng noahziheng self-assigned this Sep 21, 2022
@hyj1991 hyj1991 merged commit 8e33bed into artusjs:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants