-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scanner): add parsed pluginConfig to manifest #197
feat(scanner): add parsed pluginConfig to manifest #197
Conversation
Codecov ReportBase: 90.71% // Head: 90.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 90.71% 90.76% +0.04%
==========================================
Files 48 48
Lines 1099 1104 +5
Branches 195 197 +2
==========================================
+ Hits 997 1002 +5
Misses 102 102
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
给 {
items: [ ],
config: { },
relative: boolean
} 实践中一般 |
@hyj1991 这里有个问题是现在 config 支持 Function 模型,这样的话其值是动态的 cc @JerrysShan |
这确实是一个问题,那么考虑将明确静态的配置导出到 |
那感觉还是要特定化 frameworkConfig 可以放进来,对于其他的配置项,还得是走动态 dump app.config 这种运行时分析方案 |
7e663ce
to
55a7db9
Compare
其实 #196 和本 PR 有类似的问题,我在想既然 好处是:
|
@hyj1991 我个人认为有点激进了,对目前的设计冲击似乎太大,转个 Issue 讨论下吧 |
嗯,我可以搞个 POC 看看对目前的逻辑的冲击,到时候和 RFC 一并放出来,本 PR 和 #196 作为关联项作为参考 |
本 PR 向 Manifest 类型定义和 Scanner.scan 方法逻辑中增加了
pluginConfig
字段,值为经解析后的插件配置,用于: