Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the user-configured framework is preferred #191

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented Sep 6, 2022

此 PR 旨在调整 Scanner 扫描文件阶段,用户配置的 framework 属性优先于 Scanner 传入的 framework 配置

Reference: close #187

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Base: 89.97% // Head: 89.97% // No change to project coverage 👍

Coverage data is based on head (85e9742) compared to base (f979eb9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files          50       50           
  Lines        1127     1127           
  Branches      196      196           
=======================================
  Hits         1014     1014           
  Misses        113      113           
Impacted Files Coverage Δ
src/scanner/scan.ts 95.07% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hyj1991 hyj1991 requested a review from noahziheng September 6, 2022 06:44
@hyj1991 hyj1991 marked this pull request as draft September 6, 2022 07:10
@hyj1991 hyj1991 marked this pull request as ready for review September 6, 2022 08:00
Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahziheng noahziheng merged commit 162b12b into artusjs:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Scan 阶段 Framework 的优先级问题
3 participants