-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove DefineTrigger #188
Conversation
Codecov ReportBase: 90.00% // Head: 89.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 90.00% 89.97% -0.04%
==========================================
Files 51 50 -1
Lines 1131 1127 -4
Branches 196 196
==========================================
- Hits 1018 1014 -4
Misses 113 113
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
此 PR 旨在移除 core 中提供的装饰器
DefineTrigger
,但是保留 Trigger 的基类以供上层协议实现继承。后续自定义的协议 Trigger 继承 core 提供的基类,纳入 IoC 容器管理,通过
Inject
注入使用即可,参见:测试样例Reference