Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support resolve plugin path from framework #161

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented Aug 3, 2022

此 PR 旨在对插件正确寻址:每一层 framework 定义的插件如果使用 package 属性,则应当在 path 寻址时以对应的 framework path 为基础路径进行 require.resolve 操作,从而使得插件寻址这个动作是一个确定的结果。

@hyj1991 hyj1991 requested review from noahziheng and JerrysShan and removed request for noahziheng August 3, 2022 13:10
Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahziheng noahziheng merged commit 5a3ebff into artusjs:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants