refactor: remove getContainer #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyj1991
reviewed
Jul 15, 2022
| @@ -11,8 +11,8 @@ import { ArtusLogger, Logger } from './logger'; | |||
|
|
|||
| export class ArtusApplication implements Application { | |||
| public manifest?: Manifest; | |||
| public container: Container; | |||
There was a problem hiding this comment.
这个 container 其实可以和 execution container 一样设置进容器：
this.container.set({id: Container, value: this.container});不需要作为 public 属性对外使用，这样外部想用可以直接 Inject
There was a problem hiding this comment.
- 进容器的改动已经做在 feat: load default class early #139 里面了
- 对于上层框架来说，还是有可能会用到 app.contianer，就像现在广泛使用了的 app.getContainer() 和 ctx.container，即然管不住还不如放开，推荐 Inject 就是了
noahziheng
force-pushed
the
refactor/remove-get-container
branch
from
e26ea64 to
57d256e
Compare
hyj1991
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #141