Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scanner): modify exclude option for plugin & excluded rename #134

Merged
merged 6 commits into from
Jul 13, 2022

Conversation

noahziheng
Copy link
Member

related #129
改动点如下:

  • BREAKING! Scanner 中所有 excluded 均调整为 exclude
  • Scanner.formatWalkOptions 补充逻辑: exclude 使用默认常量序列 + 插件 Meta 中声明的 exclude 值(未声明为空)

对于 #129 实现中的其他部分:

  • extensions 目前看不涉及单独配置,暂不考虑支持
  • Framework 中目前未包括对 Metadata 的处理(不要求 meta.yaml),此处需要评估是否有必要增加,或在其他位置声明 exclude/configDir(如 package.json)cc @hyj1991

cc @hyj1991 @JerrysShan @wengeezhang

@hyj1991
Copy link
Member

hyj1991 commented Jul 13, 2022

meta.yml 其实没必要强制吧,framework 和 plugin 不一样,它不需要 name,pluin 是因为至少要有一个 name 才必须检测 meta.yml

@hyj1991
Copy link
Member

hyj1991 commented Jul 13, 2022

其实这些非标的文件,会给后面 ts 构建到 js 发包带来一些麻烦,这个还没想好怎么统一处理掉

cc @JerrysShan @DuanPengfei ,可以一起看看有啥好的想法没

@noahziheng
Copy link
Member Author

单测已补充

@hyj1991 Framework 的 Meta 后面专门处理一下吧,有关这几个非标文件的处理我有个想法,晚点整理个 RFC

package.json Show resolved Hide resolved
@noahziheng noahziheng merged commit ad76a07 into artusjs:master Jul 13, 2022
@wengeezhang wengeezhang self-requested a review July 13, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants