feat(loader): add getConfigMetaFromFilename util

src/loader/impl/config.ts

@@ -1,17 +1,13 @@
 import * as path from 'path';
 import { Container } from '@artus/injection';
 import ConfigurationHandler from '../../configuration';
-import { ArtusInjectEnum, ARTUS_DEFAULT_CONFIG_ENV, CONFIG_PATTERN } from '../../constant';
+import { ArtusInjectEnum, CONFIG_PATTERN } from '../../constant';
 import { DefineLoader } from '../decorator';
 import { ManifestItem, Loader, LoaderFindOptions } from '../types';
 import compatibleRequire from '../../utils/compatible_require';
 import { isMatch } from '../../utils';
 import { Application } from '../../types';
-
-export interface ConfigFileMeta {
-  env: string;
-  namespace?: string;
-}
+import { getConfigMetaFromFilename } from '../utils/config_file_meta';
 
 @DefineLoader('config')
 class ConfigLoader implements Loader {
@@ -42,7 +38,7 @@ class ConfigLoader implements Loader {
   }
 
   async load(item: ManifestItem) {
-    const { namespace, env } = await this.getConfigFileMeta(item);
+    const { namespace, env } = getConfigMetaFromFilename(item.filename);
     let configObj = await this.loadConfigFile(item);
     if (namespace) {
       configObj = {
@@ -53,21 +49,6 @@ class ConfigLoader implements Loader {
     return configObj;
   }
 
-  protected async getConfigFileMeta(item: ManifestItem): Promise<ConfigFileMeta> {
-    let [namespace, env, extname] = item.filename.split('.');
-    if (!extname) {
-      // No env flag, set to Default
-      env = ARTUS_DEFAULT_CONFIG_ENV.DEFAULT;
-    }
-    const meta: ConfigFileMeta = {
-      env,
-    };
-    if (namespace !== 'config') {
-      meta.namespace = namespace;
-    }
-    return meta;
-  }
-
   protected async loadConfigFile(item: ManifestItem): Promise<Record<string, any>> {
     const originConfigObj = await compatibleRequire(item.path);
     let configObj = originConfigObj;

src/loader/impl/framework_config.ts

@@ -4,6 +4,7 @@ import { ManifestItem, Loader, LoaderFindOptions } from '../types';
 import { FRAMEWORK_PATTERN } from '../../constant';
 import ConfigLoader from './config';
 import { isMatch } from '../../utils';
+import { getConfigMetaFromFilename } from '../utils/config_file_meta';
 
 @DefineLoader('framework-config')
 class FrameworkConfigLoader extends ConfigLoader implements Loader {
@@ -15,7 +16,7 @@ class FrameworkConfigLoader extends ConfigLoader implements Loader {
   }
 
   async load(item: ManifestItem) {
-    const { env } = await this.getConfigFileMeta(item);
+    const { env } = getConfigMetaFromFilename(item.filename);
     const configObj = (await this.loadConfigFile(item)) as FrameworkObject;
     this.configurationHandler.addFramework(item.source || 'app', configObj, {
       env,

src/loader/impl/plugin_config.ts

@@ -4,6 +4,7 @@ import { PluginConfigItem } from '../../plugin/types';
 import { isMatch } from '../../utils';
 import { DefineLoader } from '../decorator';
 import { ManifestItem, Loader, LoaderFindOptions } from '../types';
+import { getConfigMetaFromFilename } from '../utils/config_file_meta';
 import ConfigLoader from './config';
 
 @DefineLoader('plugin-config')
@@ -16,7 +17,7 @@ class PluginConfigLoader extends ConfigLoader implements Loader {
   }
 
   async load(item: ManifestItem) {
-    const { env } = await this.getConfigFileMeta(item);
+    const { env } = getConfigMetaFromFilename(item.filename);
     const configObj = await this.loadConfigFile(item);
     for (const pluginName of Object.keys(configObj)) {
       const pluginConfigItem: PluginConfigItem = configObj[pluginName];

src/loader/utils/config_file_meta.ts

@@ -0,0 +1,21 @@
+import { ARTUS_DEFAULT_CONFIG_ENV } from '../../constant';
+
+export interface ConfigFileMeta {
+  env: string;
+  namespace?: string;
+}
+
+export const getConfigMetaFromFilename = (filename: string): ConfigFileMeta => {
+  let [namespace, env, extname] = filename.split('.');
+  if (!extname) {
+    // No env flag, set to Default
+    env = ARTUS_DEFAULT_CONFIG_ENV.DEFAULT;
+  }
+  const meta: ConfigFileMeta = {
+    env,
+  };
+  if (namespace !== 'config') {
+    meta.namespace = namespace;
+  }
+  return meta;
+};