Adds a Node interface to Sale #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will address the test failures on Monday. |
|
This will probably be useful for getting the tests to pass: https://medium.com/@boriscoder/the-hidden-power-of-jest-matchers-f3d86d8101b0 |
mzikherman
reviewed
Oct 28, 2017
| @@ -12,6 +13,8 @@ import { connectionFromArraySlice, connectionDefinitions } from "graphql-relay" | |||
| import { amount } from "schema/fields/money" | |||
| import { exclude } from "lib/helpers" | |||
| import { map } from "lodash" | |||
There was a problem hiding this comment.
You can add has here and avoid the import below.
mzikherman
reviewed
Oct 28, 2017
| @@ -47,6 +47,7 @@ const SupportedTypes = { | |||
| "./partner", | |||
| "./partner_show", | |||
| "./show", | |||
| "./sale", | |||
mzikherman
reviewed
Oct 28, 2017
| @@ -59,6 +62,8 @@ const saleArtworkConnection = connectionDefinitions({ | |||
|
|
|||
| const SaleType = new GraphQLObjectType({ | |||
| name: "Sale", | |||
| interfaces: [NodeInterface], | |||
| isTypeOf: obj => _.has(obj, "is_auction") && _.has(obj, "currency"), | |||
|
Nice! I've experienced that before- adding the |
|
Thanks! I've written up some notes and will add what I learned to the wiki for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work from #794. Paired with @orta. This is required to get Relay working with Emission for sales.