[hold] upgrade: Webpack 5 #6496
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import jade from "jade" | ||
| import path from "path" | ||
| import { first, isArray } from "lodash" | ||
|
|
||
| type RenderOptions = { | ||
| basePath?: string, | ||
| compilerOptions?: object, | ||
| locals?: object, | ||
| } | ||
|
|
||
| export default function renderTemplate(templates: string, options: RenderOptions): string; | ||
| export default function renderTemplate(templates: string[], options: RenderOptions): string[]; | ||
| export default function renderTemplate(templates: string | string[], options: RenderOptions = {}): string | string[] { | ||
| const normalizedTemplates = isArray(templates) ? templates : [templates] | ||
|
|
||
| const { basePath = "", compilerOptions = {}, locals = {} } = options | ||
|
|
||
| const templateFns = normalizedTemplates.map(file => { | ||
| return jade.compileFile(path.join(basePath, file), compilerOptions) as (obj: any) => string | ||
| }) | ||
|
|
||
| const renderedTemplates = templateFns.map(template => template(locals)) | ||
|
|
||
| // If user only passed in a single template, return a single template | ||
| const out = | ||
| renderedTemplates.length > 1 ? renderedTemplates : first(renderedTemplates) | ||
|
|
||
| return out | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,12 +4,8 @@ const chalk = require("chalk") | |
| const fs = require("fs") | ||
| const path = require("path") | ||
| const webpack = require("webpack") | ||
| const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin") | ||
| const WebpackNotifierPlugin = require("webpack-notifier") | ||
| const { basePath, env } = require("../utils/env") | ||
|
|
||
| const cacheDirectory = path.resolve(basePath, ".cache") | ||
|
|
@@ -18,7 +14,7 @@ if (!env.onCi && !fs.existsSync(cacheDirectory)) { | |
| console.log( | ||
| chalk.yellow( | ||
| "\n[!] No existing `.cache` directory detected, initial " + | ||
| "launch will take a while.\n" | ||
| ) | ||
| ) | ||
| } | ||
|
|
@@ -56,29 +52,13 @@ export const clientDevelopmentConfig = { | |
| ], | ||
| }, | ||
| plugins: [ | ||
|
There was a problem hiding this comment. This was recently added because it helped us track down a very pesky case sensitive bug. Why remove? There was a problem hiding this comment. If all of the following removals are due to plugin compat, we should comment them out with a unless there are comparable built-in webpack features we can leverage. There was a problem hiding this comment. Would you explain the particular bug in more detail or provide a link to it? I am intimately familiar with Apples case-insensitive file system and the many issues that it creates in particular when renaming files in git. However git has options to address this already and wonder if we could instead leverage those. There was a problem hiding this comment. #6462 was the issue that prompted this — I had downcased a folder name accidentally against convention, but imports would work locally with alternate casing. I'd very much like to be warned about this, regardless of where it happens. There was a problem hiding this comment. (Er, that's not the issue but rather the fix) |
||
| new webpack.HotModuleReplacementPlugin(), | ||
| new ForkTsCheckerWebpackPlugin({ | ||
| formatter: "codeframe", | ||
| formatterOptions: "highlightCode", | ||
| checkSyntacticErrors: true, | ||
| watch: ["./src"], | ||
| }), | ||
| new WebpackNotifierPlugin(), | ||
| ], | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to extract these babel updates into their own PR if we can easily isolate.