Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@damassi => [Dev] Add plug in to warn about case insensitive imports #6463

Merged
merged 1 commit into from
Oct 12, 2020
Merged

@damassi => [Dev] Add plug in to warn about case insensitive imports #6463

merged 1 commit into from
Oct 12, 2020

Conversation

mzikherman
Copy link
Contributor

Let's see if this works on those occasional issues!

damassi
damassi approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@damassi
Copy link
Member

damassi commented Oct 12, 2020

#mergeOnGreen

@damassi
Copy link
Member

damassi commented Oct 12, 2020

(Still some casing issues that this caught)

@mzikherman
Copy link
Contributor Author

Actually those are real ❌ on CI, since CI runs in a case-sensitive environment.

@artsy-peril artsy-peril bot merged commit 132dfea into master Oct 12, 2020
@damassi damassi deleted the rename-show branch October 12, 2020 21:44
@artsy-peril artsy-peril bot mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damassi damassi damassi approved these changes

Assignees

@damassi damassi

Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzikherman @damassi