Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load limited-time offer signals on the client side #14897

Merged
merged 16 commits into from
Jan 2, 2025
Merged

feat: load limited-time offer signals on the client side #14897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
99ddc48
feat: lazy load partner offer expiration
starsirius Oct 15, 2024
edf1b8f
feat: remove partner offer from primary label display
starsirius Oct 15, 2024
075e767
feat: reposition partner offer line; display empty line as placeholder
starsirius Oct 15, 2024
33c69ed
feat: remove fetching partner offer and offered price display
starsirius Oct 16, 2024
1abfd0e
fix: only show bid timer line on auction artworks
starsirius Oct 16, 2024
a2a2b37
refactor: use fixed height rather than fixed number of lines
starsirius Oct 16, 2024
74f1cfd
fix: do not render partner offer line with no offer
starsirius Oct 16, 2024
9553f3e
feat: overwrite public pricing after fetching offers
starsirius Oct 17, 2024
19c71ef
feat: don't render primary label when there is a partner offer
starsirius Nov 11, 2024
9fc929b
feat: move limited-time offer back to the badge line
starsirius Nov 11, 2024
f89a872
refactor: extract SaleMessage component and query renderer
starsirius Nov 12, 2024
46004bc
test: add tests
starsirius Nov 15, 2024
7a0c4a5
fix: fix types
starsirius Nov 21, 2024
8044546
refactor: DRY
starsirius Nov 21, 2024
1b2dc98
test: act before assertion
starsirius Nov 22, 2024
46fc278
feat: guard clientside signals behind a feature flag
starsirius Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Components/Artwork/Details/BidTimerLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Text } from "@artsy/palette"
import { EmptyLine } from "Components/Artwork/Details/Details"
import { useArtworkGridContext } from "Components/ArtworkGrid/ArtworkGridContext"
import { useAuctionWebsocket } from "Utils/Hooks/useAuctionWebsocket"
import { useTimer } from "Utils/Hooks/useTimer"
Expand Down Expand Up @@ -64,7 +63,7 @@ export const BidTimerLine: React.FC<
}

if (!lotClosesAt || numDays > 5 || hasBiddingEnded) {
return <EmptyLine />
return null
}

const renderLotCloseTime = [
Expand Down
Loading