Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: defer SWA login/signup prompt in SWAFooter/SWAStickyFooter #14144

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dblandin
Copy link
Member

@dblandin dblandin commented Jul 2, 2024

The type of this PR is: Feat

Description

Follow-up to artsy/force#14049.

The login/signup prompt within the SWA flow is no deferred to right before a user is able to submit a draft. This earlier prompt is no longer necessary.

Follow-up to [#14049][].

[#14049]: #14049

The login/signup prompt within the SWA flow is no deferred to right before a
user is able to submit a draft. This earlier prompt is no longer necessary.
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@olerichter00 olerichter00 merged commit 16eb125 into main Jul 3, 2024
11 checks passed
@olerichter00 olerichter00 deleted the dblandin/swa-footer-defer-login-follow-up branch July 3, 2024 10:02
@artsy-peril artsy-peril bot mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants