Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow scrolling from any part of the add photos page #14141

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Jul 2, 2024

The type of this PR is: Fix

This PR solves [PROJECT-XX]

Description

Allow scrolling from any part of the add photos page

scroll.mov

Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

<FadeInBox maxWidth="100vw" width={CONTENT_WIDTH} p={2} pt={[2, 4]}>
{children}
</FadeInBox>
<Flex width={size} justifyContent="center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work as well without useWindowSize().

Suggested change
<Flex width={size} justifyContent="center">
<Flex width="100vw" justifyContent="center">

@dariakoko dariakoko added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Jul 2, 2024
@artsy-peril artsy-peril bot merged commit b1b3920 into main Jul 2, 2024
11 checks passed
@artsy-peril artsy-peril bot deleted the dariakoko/allow-scroll-from-any-part-of-the-page branch July 2, 2024 14:41
@artsy-peril artsy-peril bot mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants