Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke todos #293

Merged
merged 2 commits into from
Jan 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ArtsyFolio Tests/Models/DocumentModelTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@
expect(document.thumbnailFilePath).to.equal(document.genericTextDocumentFilePath);
});

// The stub isn't letting methods go into parent classes, so the test fail.
// TODO: Figure how to work around.

pending(@"subclasses", ^{
it(@"returns the right filepath if the file exists", ^{
ShowDocument *document = [ShowDocument modelFromJSON:@{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ + (NSPredicate *)compoundPredicateForScopedArtworksWithInitialPredicate:(NSPredi
[predicates addObject:[NSPredicate predicateWithFormat:@"isAvailableForSale == %@", @(YES)]];
}

// TODO: https://github.com/artsy/energy/issues/643
[predicates addObject:[NSPredicate predicateWithFormat:@"images.@count > 0"]];
[predicates addObject:[NSPredicate predicateWithFormat:@"ANY images.processing == %@ ", @(NO)]];

Expand All @@ -58,7 +57,6 @@ + (NSPredicate *)compoundPredicateForArtworksWithDefaults:(NSUserDefaults *)defa
[predicates addObject:[NSPredicate predicateWithFormat:@"ANY artworks.isAvailableForSale == %@", @(YES)]];
}

// TODO: https://github.com/artsy/energy/issues/641
[predicates addObject:[NSPredicate predicateWithFormat:@"artworks.@count > 0"]];

return [NSCompoundPredicate andPredicateWithSubpredicates:predicates];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ - (instancetype)initWithShow:(Show *)show
- (void)viewDidLoad
{
[super viewDidLoad];

// TODO: Why does this exist?
self.view.clipsToBounds = YES;
}

Expand Down
1 change: 0 additions & 1 deletion Classes/Data Sources/ARBrowseProvider.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ typedef NS_ENUM(NSUInteger, ARBrowseDisplayMode) {

@property (nonatomic, assign, readwrite) ARBrowseDisplayMode currentDisplayMode;

// TODO: rename this guy? I'm just going with the established terminology
@property (nonatomic, assign, readwrite) NSManagedObject *selectedItem;

@property (nonatomic, strong, readwrite) NSManagedObjectContext *managedObjectContext;
Expand Down
2 changes: 0 additions & 2 deletions Classes/Data Sources/ARBrowseProvider.m
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ - (void)refreshWithTableView:(UITableView *)tableView
// (and pretty awkward to have to pass the TV in)
// but it's gotta go somewhere right?

// TODO: make this cleaner

[tableView registerClass:[ARTableViewCell class] forCellReuseIdentifier:CellIdentifier];

NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
Expand Down
2 changes: 0 additions & 2 deletions Classes/Models/Artist.m
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ - (NSFetchRequest *)sortedArtworksFetchRequest
return [self artworksFetchRequestSortedBy:order];
}

// TODO: Why are these methods so similar? #644

- (NSString *)searchDisplayName
{
if (self.displayName) {
Expand Down
1 change: 0 additions & 1 deletion Classes/Spotlight/ARSpotlightExporter.m
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ - (instancetype)initWithIndex:(CSSearchableIndex *)index

- (void)syncDidFinish:(ARSync *)sync
{
// TODO: Move to DI
self.context = sync.config.managedObjectContext;
[self updateCache];
}
Expand Down
1 change: 0 additions & 1 deletion Classes/Sync/ARSyncDeleter.m
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ - (instancetype)init

- (void)syncDidStart:(ARSync *)sync
{
// TODO: DI the context instead of using a property
self.context = sync.config.managedObjectContext;

NSArray *allClassesToRemoveIfNeeded = @[ Artwork.class, Artist.class, Image.class, Document.class, Show.class, Location.class ];
Expand Down
2 changes: 0 additions & 2 deletions Classes/Util/Debugging/ARLogging.m
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ + (void)setup
[self addDailyLogWithContext:ARLogContextSync];
[self addDailyLogWithContext:ARLogContextAppLifecycle];
[self addDailyLogWithContext:ARLogContextErrors];

// TODO: File logs for the various specialized contexts
}

+ (void)addDailyLogWithContext:(ARLogContext)context
Expand Down
2 changes: 0 additions & 2 deletions Classes/Views/Grid View & Items/ARGridView.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@
/// Title which shows above the items in on the phone
@property (readwrite, nonatomic, copy) NSString *title;

/// The fetch result that get's set on the datasource
/// TODO? Could this just be bypassed?
- (void)setResults:(NSFetchRequest *)fetchRequest;

/// NSManagedObjectContext for storing the cache data
Expand Down
1 change: 0 additions & 1 deletion Externals/RESTKit/NSManagedObject+ActiveRecord.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ @implementation NSManagedObject (ActiveRecord)

#pragma mark - RKManagedObject methods

// TODO: Not sure that we even need the objectStore...
+ (NSManagedObjectContext *)managedObjectContext
{
NSManagedObjectContext *context = nil;
Expand Down