This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Make sure buttons update when their enablement has changed #trivial #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
This logic in the button component sorely needs some unit tests. Can you please do that asap after we’ve shipped 4.0.0? |
|
Agreed! I'll file a ticket. |
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/artsy/collector-experience/issues/849
This button relies on the presence of an
onPressprop to be enabled/disabled; before, this check only happened in the constructor. Now it should check to see if its status has changed incomponentDidUpdate.This shows the button being enabled and then disabled based on consignments information (ignore animation warnings):
#skip_new_tests