-
Notifications
You must be signed in to change notification settings - Fork 78
Conversation
Awesome - this looks like a perfect example for my jest-svg-snapshots! If #587 gets in before this, you should add one of those tests |
@orta I don't understand what this build is failing on... from what I gather, it's having issues running prettier? |
Afaik prettier runs on CI as a linter, which means it expects there to not be anything to prettify anymore. If this is the case, the output of prettier is very unhelpful, though. |
So when I lint locally, everything seems to pass and there are no changes introduced. I'm using |
Yeah, agreed on the output, it should be listing all the files that it thinks aren't the same as the format - but from here it looks like it's listing every ts/tsx file in our repo |
The command used on CI is |
IMO we're hitting a prettier bug, my guess is that |
Kk that was the final push of code / test fixing :). Hopefully this goes green and then it's good to PR @orta |
👍 |
That one time Inbox Zero is not so desirable, and we want you to inquire on artwork! 😄
Fix #591
Implementation:
Spec:
Unfortunately the text is a bit smaller than the design asks for, but then the 3rd paragraph ends up on 3 lines :(. Also the status bar 😅...