Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[MSG] Zero state for Inbox #603

Merged
merged 8 commits into from
Jun 12, 2017
Merged

[MSG] Zero state for Inbox #603

merged 8 commits into from
Jun 12, 2017

Conversation

mennenia
Copy link
Contributor

@mennenia mennenia commented Jun 9, 2017

That one time Inbox Zero is not so desirable, and we want you to inquire on artwork! 😄

Fix #591

Implementation:
screen shot 2017-06-07 at 11 01 17

Spec:
screen shot 2017-06-07 at 11 01 17

Unfortunately the text is a bit smaller than the design asks for, but then the 3rd paragraph ends up on 3 lines :(. Also the status bar 😅...

@orta
Copy link
Contributor

orta commented Jun 9, 2017

Awesome - this looks like a perfect example for my jest-svg-snapshots! If #587 gets in before this, you should add one of those tests

@orta orta mentioned this pull request Jun 9, 2017
@mennenia
Copy link
Contributor Author

@orta I don't understand what this build is failing on... from what I gather, it's having issues running prettier?

@alloy
Copy link
Contributor

alloy commented Jun 12, 2017

Afaik prettier runs on CI as a linter, which means it expects there to not be anything to prettify anymore. If this is the case, the output of prettier is very unhelpful, though.

@mennenia
Copy link
Contributor Author

So when I lint locally, everything seems to pass and there are no changes introduced. I'm using yarn lint, nothing specific to prettier. Should I be using a different command?

@orta
Copy link
Contributor

orta commented Jun 12, 2017

Yeah, agreed on the output, it should be listing all the files that it thinks aren't the same as the format - but from here it looks like it's listing every ts/tsx file in our repo

@alloy
Copy link
Contributor

alloy commented Jun 12, 2017

The command used on CI is yarn prettier-project -- -l

@orta
Copy link
Contributor

orta commented Jun 12, 2017

IMO we're hitting a prettier bug, my guess is that -l isn't taking ENV["CI"] into account and so shows both "passing" and "failing"

@mennenia
Copy link
Contributor Author

Kk that was the final push of code / test fixing :). Hopefully this goes green and then it's good to PR @orta

@orta
Copy link
Contributor

orta commented Jun 12, 2017

👍

@orta orta merged commit 4dedf51 into master Jun 12, 2017
@orta orta deleted the mc-inboxzero branch June 12, 2017 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants