This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[MX-166] handle images without deep zoom #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
approved these changes
Jan 30, 2020
|
|
||
| if (result.some(image => !image.deepZoom)) { | ||
| if (!__DEV__) { | ||
| Sentry.captureMessage(`No deep zoom for at least one image on artwork (see breadcrumbs for artwork slug)`) |
src/lib/Scenes/Artwork/Components/ImageCarousel/ImageCarousel.tsx
Outdated
Show resolved
Hide resolved
|
Following up on the deeper (get it?) discussion, I think the approach you took makes sense. Given how rare this is, the slightly degraded UX is acceptable to me (and certainly much better than WSOD). Thanks for outlining the trade-offs 👍 #mergeongreen |
|
🚀 PR was released in v1.21.30 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/MX-166
To recap: the problem was that some images in our system don't have a deepZoom property for mysterious reasons. This was causing an uncaught error in the full screen carousel component which crashed the artwork page, showing the ol' White Screen Of Death 'retry' screen.
Working around this was complicated because what if an artwork with multiple images had just one of the images lacking deepZoom data? The full screen carousel lets you swipe between deepZoom images and is not set up to handle the deepZoom info not being present. So as a quick fix for this (seemingly very very rare) situation was as follows:
It ain't perfect (leads to us potentially not showing images a partner has uploaded) but it'll at least prevent WSOD situations.
I think the other quick-and-dirty fix would be to disable deep zoom if an artwork has at least one image lacking deepZoom info, but given how rare this is I'm not too bothered either way.