Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CX-2486): show network status during the Onboarding #7666

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix(CX-2486): show network status during the Onboarding #7666

merged 1 commit into from
Nov 16, 2022

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Nov 16, 2022 •
edited by jira bot
Loading

This PR resolves CX-2486

Description

Show network status during the Onboarding. This was broken because of an old version of react native device info.

On Android

Screen.Recording.2022-11-16.at.16.20.29.mov

On iOS

RPReplay_Final1668612112.MP4

PR Checklist

  • I tested my changes on iOS / Android.
  • I added screenshots or videos to illustrate my changes.
  • I added Tests and Stories for my changes.
  • I added an app state migration.
  • I hid my changes behind a feature flag. _ a feature flag is available already to hide the network status_
  • I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Fix Network status modal during the Onboarding - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri requested a review from MrSltun November 16, 2022 15:24
MrSltun
MrSltun previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@MrSltun MrSltun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🌟 Thank you Mounir!
But what's the message about @react-native-community/viewpager doing here 👀 I don't see any addition to the package.json
it's gone now :)

@MounirDhahri MounirDhahri force-pushed the chore/show-internet-status-on-login branch from c97e776 to db0271c Compare November 16, 2022 15:48
@MounirDhahri
Copy link
Member Author

@MrSltun I am fixing the merge conflicts now 😄

@MounirDhahri MounirDhahri force-pushed the chore/show-internet-status-on-login branch from db0271c to 92427bd Compare November 16, 2022 15:50
@MounirDhahri MounirDhahri changed the title fix: show network status during the Onboarding fix(CX-2486): show network status during the Onboarding Nov 16, 2022
@MounirDhahri
Copy link
Member Author

done

@MrSltun MrSltun added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Nov 16, 2022
@artsy-peril artsy-peril bot merged commit f823778 into main Nov 16, 2022
@artsy-peril artsy-peril bot deleted the chore/show-internet-status-on-login branch November 16, 2022 17:04
Bkh84 pushed a commit to StonlyHQ/Artsy-Stonly that referenced this pull request Nov 24, 2022
@MounirDhahri @Bkh84
fix(CX-2486): show network status during the Onboarding (artsy#7666)
d1c2812 
fix: make no network provider work again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSltun MrSltun MrSltun left review comments

Assignees

@MrSltun MrSltun

Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MounirDhahri @MrSltun