Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NSInternalInconsistencyException sentry crash iOS 17 #11243

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Dec 4, 2024

This PR resolves PHIRE-1389

Description

Fixes this iOS sentry crash.

By looking for this issue found connections with two of our deps:

  1. react-native-linear-gradient
  2. react-native-fast-image

The react-native-linear-gradient has already fixed the issue and released a version so bumping in order to fix the issue from there.

For react-native-fast-image we need to patch it temporarily until they release this with a new version.

Related issues:
react-native-linear-gradient/react-native-linear-gradient#618
DylanVann/react-native-fast-image#1002

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

  • fixes iOS 17 image crash

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis changed the title fix: fix: NSInternalInconsistencyException sentry crash iOS 17 Dec 4, 2024
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • iOS user-facing changes (fixes iOS 17 image crash - gkartalis)

Generated by 🚫 dangerJS against ffd0242

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! how did you notice it?

@gkartalis
Copy link
Member Author

@MounirDhahri As I was monitoring the releases from the latest ios sentry release and filtering unhandled crashes

@gkartalis gkartalis added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Dec 4, 2024
@MounirDhahri
Copy link
Member

thanks - glad someone is doing that

@artsy-peril artsy-peril bot merged commit e330e64 into main Dec 4, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the gkartalis/PHIRE-1389 branch December 4, 2024 10:58
@dariakoko
Copy link
Contributor

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants