Check pagination size before adding pagination numbers #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a clever trick inside of Eleventy if you're wanting to create single views from an array of items, by using the pagination option and setting a
size
of1
. The best example of this is within the Eleventy docs where it's used to produce tag pagesPrior to this change paginated pages would show a page number as well as apply a "noindex" meta value to the page. This is undesirable if you're using the aforementioned method to produce pages. This change checks if the
size
value is above1
and then applies the page number andnoindex
value. I've tested this on a development project and added tests to the PR, which appear to be passing. Fixes #27PS. Wasn't sure which branch to put this against, let me know if it's meant to be
master
instead ofdevelop
👍🏻