Update to support unit32 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this update artonge/go-gtfs#22, the sequence always returned 0 because this library didn't support uint32. This should fix the issue. Tested with the go-gtfs library with this change.
artonge
reviewed
Jun 27, 2023
edfungus
commented
Jul 13, 2023
artonge
approved these changes
Jul 13, 2023
|
I let you decide about the format thing. Once resolve, feel free to merge :) |
|
I don't have perms to merge, so I'll let you do it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this update artonge/go-gtfs#22, the sequence always returned 0 because this library didn't support uint32. This should fix the issue. Tested with the go-gtfs library with this change.