Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the updates to the menu tools for producing matching efficiencies, trigger turn ons, scalings, and rates for new/updated TJM objects. In particular:
Some notes:
Scaling thresholds for SC8 jets can not use the default ones defined in
scaling_thresholds.yaml
, as there is a pt>100 GeV cut applied to Gen AK8 jets in the nano. Can we define a different set of thresholds specifically for these? Or reduce the pt cut for Gen AK8 in the nano?I udpated some of the core parts of the rate tools to work with nano, basically implementing the same changes already done for the efficiency parts of the code.
In some cases (caching for MinBias, trigger efficiency for taus, rate plot), I copied a config file from v32 and adapted it to work for the nano, and only for the objects I have been looking at.
I had to "extract" some of the changes from a working directory I was using, so there may be one or two fixes required.