-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Linux Mint Support #515
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
24aa7d2
feat: added Linux Mint Support
fkonradmain b013af4
feat: added linuxmint test image, added meta information, added autom…
fkonradmain e76c8ab
Merge branch 'main' of https://github.com/fkonradmain/ansible-role-ta…
fkonradmain 59629da
Merge branch 'main' of https://github.com/fkonradmain/ansible-role-ta…
fkonradmain e4257c3
fix: fixed linter warnings
fkonradmain f114de3
fix: introduced common.yaml as shared dependency among debian install…
fkonradmain 90dcc19
fix: renamed apt-codename.yml dependency
fkonradmain 22a5584
Fix typo in apt-codename.yml
fkonradmain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
--- | ||
# Retrieve "ID_LIKE" from /etc/os-release | ||
# ID_LIKE has the following values, depending on the operating system | ||
# | OS | ID_LIKE | | ||
# | Debian | -- does not exist -- | | ||
# | Raspberry Pi OS | -- does not exist -- | | ||
# | Proxmox | -- does not exist -- | | ||
# | Devuan | "debian" | | ||
# | Raspbian | "debian" | | ||
# | Ubuntu | "debian" | | ||
# | Pop!OS | "ubuntu debian" | | ||
# | Linux Mint | "ubuntu debian" | | ||
Comment on lines
+2
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great comment block, thank you! |
||
- name: Debian | Retrieve Apt ID_LIKE | ||
check_mode: false | ||
ansible.builtin.command: >- | ||
awk -F= '/^ID_LIKE/ {print $2}' {{ ansible_distribution_file_path }} | ||
register: apt_id_like | ||
changed_when: false | ||
|
||
# Ubuntu and its derivatives all have a value called "UBUNTU_CODENAME" set in their "/etc/os-release" | ||
# This value points to the actual ubuntu Version. | ||
# Ansible does not pick up that value on setup. Usually it picks up "VERSION_CODENAME" | ||
- name: Debian | Retrieve ubuntu_codename on Ubuntu derivatives | ||
check_mode: false | ||
ansible.builtin.command: >- | ||
awk -F= '/^UBUNTU_CODENAME/ {print $2}' {{ ansible_distribution_file_path }} | ||
register: ubuntu_codename | ||
when: apt_id_like.stdout == '"ubuntu debian"' | ||
changed_when: false | ||
|
||
- name: Debian | Set codename for apt | ||
ansible.builtin.set_fact: | ||
apt_codename: "{{ ubuntu_codename.stdout | default(ansible_distribution_release) }}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artis3n I don't see this pop up in the test suite. Does this need additional approval from your side as owner or did I miss anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request_target
works by running the version of this file on the main branch against the code we check out. Needed to safely use my tailscale key to run the CI. Side effect is any changes to this file won't reflect in tests until it is merged.To test this container, I run
MOLECULE_DISTRO="ghcr.io/fkonradmain/docker-linuxmint22-ansible:latest" make test
locally (or the other test commands in the Makefile)