Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [BUG] If tailscale_up_timeout is bigger than 60s... #426

Merged
merged 6 commits into from
Feb 7, 2024
Merged

fix: [BUG] If tailscale_up_timeout is bigger than 60s... #426

merged 6 commits into from
Feb 7, 2024

Conversation

McSim85
Copy link
Contributor

@McSim85 McSim85 commented Feb 6, 2024

This PR is the fix for
#424

@McSim85
Copy link
Contributor Author

McSim85 commented Feb 6, 2024

Tried to run tests in Codespace, but seems like, there is a poerty missed:

@McSim85 ➜ /workspaces/ansible_role_tailscale (fix-timout-async-conflict) $ make test-default
poetry run molecule test --scenario-name default
make: poetry: No such file or directory
make: *** [Makefile:44: test-default] Error 127
@McSim85 ➜ /workspaces/ansible_role_tailscale (fix-timout-async-conflict) $

@McSim85
Copy link
Contributor Author

McSim85 commented Feb 7, 2024

Regarding the devcontainer, are you sure the creation finished successfully? Note the installation of poetry here: https://github.com/artis3n/ansible-role-tailscale/blob/main/.devcontainer/devcontainer.json#L17

Edit: you know what, I probably need to do #427 since we moved to python 3.12 in this repo.

yeah. Now it's working, and tests are passing with no errors. 👍

artis3n
artis3n approved these changes Feb 7, 2024
View reviewed changes
Copy link
Owner

@artis3n artis3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@artis3n artis3n merged commit 8bf2072 into artis3n:main Feb 7, 2024
29 checks passed
@McSim85 McSim85 deleted the fix-timout-async-conflict branch February 8, 2024 12:56
kieranmanning pushed a commit to kieranmanning/ansible-role-tailscale that referenced this pull request Dec 14, 2024
@McSim85 @artis3n
fix: [BUG] If tailscale_up_timeout is bigger than 60s... (artis3n#426)
0e50b8a 
* fix: [BUG] If tailscale_up_timeout is bigger than 60s...

* add type check

* fix fail condition

* add zero check condition

---------

Co-authored-by: Ari Kalfus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artis3n artis3n artis3n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McSim85 @artis3n