This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
feat: add slice for routing POST requests
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genryxy
requested review from
a team and
olenagerasimova
and removed request for
a team
# Conflicts: # src/main/resources/dashboard/user.hbs
olenagerasimova
previously approved these changes
Nov 29, 2021
|
@g4s8 could you please check/merge |
|
@g4s8 could you please take a look |
g4s8
suggested changes
Dec 6, 2021
| @@ -35,13 +35,15 @@ repo: | |||
| - download | |||
| {{/if}}</textarea> | |||
| <input name="repo" type="hidden" value="{{name}}"/> | |||
| <input name="method" type="hidden" value="update"/> | |||
There was a problem hiding this comment.
Term method is confusing here: method in HTTP protocol is a part of request line and it also can have value delete, so I'd change it to action or similar
| <input id="config-submit" type="submit" value="Update"/> | ||
| </fieldset> | ||
| </form> | ||
|
|
||
| <form id="repo-delete-form" action="/api/repos/{{user}}?method=delete" method="POST"> | ||
| <fieldset> | ||
| <input name="repo" type="hidden" value="{{name}}"/> | ||
| <input name="method" type="hidden" value="delete"/> |
| * @checkstyle StringLiteralsConcatenationCheck (10 lines) | ||
| */ | ||
| private static String value(final String payload, final String name) { | ||
| final int start = payload.indexOf(String.format("%s=", name)) + name.length() + 1; |
There was a problem hiding this comment.
You can use some library to parse URI queries here, and I'm suggesting to URL-encode parameters, since payload may contain & chars
There was a problem hiding this comment.
Do I understand correct that both parameters name and parameters may contain &? Or in this case it would be parsed as an argument with empty value?
| * Type of method of request. | ||
| * @since 0.5 | ||
| */ | ||
| private enum Method { |
There was a problem hiding this comment.
And this class name could be renamed too
|
@g4s8 thanks, corrected |
g4s8
approved these changes
Dec 8, 2021
g4s8
added a commit
that referenced
this pull request
Dec 22, 2021
* Add absent repos * cicd(release): added release config for #38 * Fixed parameters and storage settings format in `ApiRepoUpdateSlice` Closes #39 - fixed 2 problems in ApiRepoUpdateSlice: 1) parameters separator was expected to be ; instead of & 2) storage settings were always expected to be yaml, but there also can be string for default value PR: #40 * Repo config should be url decoded Closes #39 - Body with repo configs should be url-decoded. PR: #41 * Improved updating storage settings functionality (#43) Closes #42 - simplified and fixed updating storage scenario in ApiRepoUpdateSlice. On dashboard we always work with whole yaml repo settings, so there is no need to update section by section, we can simply rewrite the whole file after checking that required fields (type and storage) are present in the new version. * fix: added repository configuration descriptions Added description for several repositories. Issue: artipie/artipie#317 PR: #44 * fix: handle errors in `ApiRepoUpdateSlice` (#45) Handle errors in `ApiRepoUpdateSlice` (#45) Closes: artipie/artipie#320 * feat(conda): added conda repository to dashboard (#46) Added anaconda repository option to dashboard and configuration description. Ticket: artipie/artipie#317 * doc: verbose link name Clarified API reference link name. Closes: #47 * fix: add rq line to get users in `FromRqLine` (#48) Part of artipie/artipie#965 Added rq line to get users in FromRqLine, corresponding test and updated http and asto. * feat: added slice for repo delete (#49) Add slice to delete a repo. Added disabled test for this slice as it is necessary to implement delete operation in FakeConfigFile class. Ticket: artipie/artipie#321 * feat: add slice for routing `POST` requests (#51) Added slice ApiRepoPostRtSlice for routing post requests by parsing body content. This class will be used in artipie module. Test will be added in next PR. Ticket: artipie/artipie#321 * deps: bumped ppom and other deps (#53) * Bumped ppom from 0.5.1 to 1.1.0 * Bumped asto from v1.9.0 to v1.10.0 * Bumped http-client from 0.3.2 to 0.3.6 * Bumped vert-server from 0.4 to 0.5 * refactor: extract class for body parsing (#52) Extract class for parsing body content for receiving some content. Close: #50 * test: enable test for delete and add for postRt (#55) Enable and a bit extend test for ApiRepoDeleteSlice and add test for ApiRepoPostRtSlice. Ref: artipie/artipie#321 * refactor: use storages instead of settings storage Co-authored-by: Kirill <[email protected]> Co-authored-by: Alena <[email protected]>
g4s8
added a commit
that referenced
this pull request
Dec 27, 2021
* Add absent repos * cicd(release): added release config for #38 * Fixed parameters and storage settings format in `ApiRepoUpdateSlice` Closes #39 - fixed 2 problems in ApiRepoUpdateSlice: 1) parameters separator was expected to be ; instead of & 2) storage settings were always expected to be yaml, but there also can be string for default value PR: #40 * Repo config should be url decoded Closes #39 - Body with repo configs should be url-decoded. PR: #41 * Improved updating storage settings functionality (#43) Closes #42 - simplified and fixed updating storage scenario in ApiRepoUpdateSlice. On dashboard we always work with whole yaml repo settings, so there is no need to update section by section, we can simply rewrite the whole file after checking that required fields (type and storage) are present in the new version. * fix: added repository configuration descriptions Added description for several repositories. Issue: artipie/artipie#317 PR: #44 * fix: handle errors in `ApiRepoUpdateSlice` (#45) Handle errors in `ApiRepoUpdateSlice` (#45) Closes: artipie/artipie#320 * feat(conda): added conda repository to dashboard (#46) Added anaconda repository option to dashboard and configuration description. Ticket: artipie/artipie#317 * doc: verbose link name Clarified API reference link name. Closes: #47 * fix: add rq line to get users in `FromRqLine` (#48) Part of artipie/artipie#965 Added rq line to get users in FromRqLine, corresponding test and updated http and asto. * feat: added slice for repo delete (#49) Add slice to delete a repo. Added disabled test for this slice as it is necessary to implement delete operation in FakeConfigFile class. Ticket: artipie/artipie#321 * feat: add slice for routing `POST` requests (#51) Added slice ApiRepoPostRtSlice for routing post requests by parsing body content. This class will be used in artipie module. Test will be added in next PR. Ticket: artipie/artipie#321 * deps: bumped ppom and other deps (#53) * Bumped ppom from 0.5.1 to 1.1.0 * Bumped asto from v1.9.0 to v1.10.0 * Bumped http-client from 0.3.2 to 0.3.6 * Bumped vert-server from 0.4 to 0.5 * refactor: extract class for body parsing (#52) Extract class for parsing body content for receiving some content. Close: #50 * test: enable test for delete and add for postRt (#55) Enable and a bit extend test for ApiRepoDeleteSlice and add test for ApiRepoPostRtSlice. Ref: artipie/artipie#321 * fix: delete from items from substorage Co-authored-by: Kirill <[email protected]> Co-authored-by: Alena <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of artipie/artipie#321
Added slice
ApiRepoPostRtSlicefor routing post requests by parsing body content. This class will be used in artipie module. Test will be added in next PR