Refactor CI and Playground build pipelines #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit separates "build / test" and "publish" into separate pipelines to prepare for uploading to GitHub Pages with GitHub Actions: - A WebApp build CI step is added which compiles the Rust code to Wasm and builds the TypeScript code into a bundle. This step never uploads to GitHub pages and runs on PRs and merges to trunk. - A "Publish" workflow is added which builds and uploads to GitHub Pages. This workflow only runs on merges to trunk. A concurrency group called "pages" is added with canceling of in flight builds if a newer commit is pushed to trunk. The publish workflow is no longer published on a weekly cronjob. This commit also contains some cleanups: - `actions-rs` GitHub Actions are replaced with bare calls to rustup and clippy, addressing artichoke/project-infrastructure#265 for the playground. - Caching is removed from `setup-emsdk` action due to an upstream bug: mymindstorm/setup-emsdk#20. - `ruby/setup-ruby` is removed from CI jobs where it is not required. - The `CARGO_NET_GIT_FETCH_WITH_CLI` env variable is set, porting a change from `strftime-ruby`. This should speed up build times when the Artichoke git repository is not cached.
lopopolo
added
A-build
14 tasks
lopopolo
added a commit
that referenced
this pull request
Sep 2, 2022
Fix a regression introduced in #909. These permissions from the GitHub Actions based publishing workflow do not work with peaceiris/actions-gh-pages@v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit separates "build / test" and "publish" into separate pipelines to prepare for uploading to GitHub Pages with GitHub Actions:
This commit also contains some cleanups:
actions-rsGitHub Actions are replaced with bare calls to rustup and clippy, addressing Remove dependencies on actions-rs GitHub Actions project-infrastructure#265 for the playground.setup-emsdkaction due to an upstream bug: Hardcoded cache key prevents multiple workflows or jobs from caching emsdk mymindstorm/setup-emsdk#20.ruby/setup-rubyis removed from CI jobs where it is not required.CARGO_NET_GIT_FETCH_WITH_CLIenv variable is set, porting a change fromstrftime-ruby. This should speed up build times when the Artichoke git repository is not cached.