Improve the quality of the emscripten_set_main_loop abstraction
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No more raw pointers. - Don't cast closures to `*mut c_void`. - Store `RefCell<Option<Box<dyn FnMut()>>>` in the thread local. - Add `'static` bound to closure type parameter, which is required for soundness. - Don't panic or segfault if the thread local does not contain a valid `FnMut`. - Remove unused imports and dead code. Remove lint `allow` pragmas. - Address clippy lints re: pointer safety and item declaration order. - Remove `F` type parameter from wrapper funtion and instead delegate to the trait object `FnMut` in the thread local.
lopopolo
added
A-wasm-build-target
lopopolo
force-pushed
the
lint-emscripten-target
branch
from
8bf3f3a to
1fd6cbd
Compare
|
trunk builds started failing after this PR was merged due to mymindstorm/setup-emsdk#20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint the playground under the
wasm32-unknown-emscriptentarget, remove raw pointers.