Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a match statement for decode checksum validation #67

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Use a match statement for decode checksum validation #67

merged 1 commit into from
Dec 21, 2020

Conversation

lopopolo
Copy link
Member

This eliminates some short-circuit returns and fallthrough logic. This
code is easier to read.

@lopopolo
Use a match statement for decode checksum validation
f7d7f9e 
This eliminates some short-circuit returns and fallthrough logic. This
code is easier to read.
@lopopolo lopopolo added C-quality Category: Refactoring, cleanup, and quality improvements. A-decode Area: Core decoder implementation. labels Dec 21, 2020
@lopopolo lopopolo merged commit 782b7e6 into trunk Dec 21, 2020
@lopopolo lopopolo deleted the decode-checksum-match branch December 21, 2020 00:58
@lopopolo lopopolo mentioned this pull request Dec 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-decode Area: Core decoder implementation. C-quality Category: Refactoring, cleanup, and quality improvements.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lopopolo