Remove bstr
and reimplement bits that are used in decode
#138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only remaining use of
bstr
inboba
was a single call toByteSlice::find_not_byteset
inboba::decode::inner
. After looking atthe
bstr
source, for an alphabet the size of bubblebabble's encoding,it computed a
[u8; 256]
lookup table and checks for membership withO(1)
array access.Because we know the alphabet ahead of time, we can pre-compute the table
and implement this with
Iterator::find
.This results in a modest 3% speedup in decode performance, mostly because
the alphabet lookup table is a pre-computed const.
boba
now has no dependencies outside ofalloc
andstd
.Benches