Fixed two-finger tap not working #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASHIJANKEN
commented
Jan 3, 2022
| for (int i = 0; i < fingersQua; i++) | ||
| { | ||
| mtPoint pos = ((Finger *)&data[i])->normalized.pos; | ||
| middleclickX += pos.x; |
There was a problem hiding this comment.
No need to explicitly set middleclickX and middleclickY to 0 here since they are set to 0 at l.249~250.
ASHIJANKEN
force-pushed
the
fix-two-finger-tap
branch
from
52e223a to
6da864a
Compare
artginzburg
approved these changes
Aug 30, 2022
|
Hi @artginzburg , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I found that the middle-click with the two-finger tap doesn't work when I changed a setting with the command below.
$ defaults write com.rouge41.middleClick fingers 2In my investigation,
f3->normalized.pos.xandf3->normalized.pos.ywere "nan" when two-finger tap was triggered.Consequently, middleclickX, middleclickY, middleclickX2, and middleclickY2 were "nan", so the condition
delta < 0.4fat l.228 didn't work well.I think the number of
((Finger *)&data[i])->normalized.posshould be aligned with fingersQua.