Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffvalidate activity, fixes #20 #36

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

djjuhasz
Copy link
Contributor

@djjuhasz djjuhasz commented Nov 1, 2024

Add an ffvalidate activity which reads a directory of files, identifies the file formats using Siegfried [1], and checks the file formats against the configured CSV list of allowed file formats.

[1] => https://github.com/richardlehane/siegfried

@djjuhasz djjuhasz force-pushed the dev/add-file-format-validate branch 2 times, most recently from 97601c4 to e25ff17 Compare November 1, 2024 21:59
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 91.12903% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (8ea34d2) to head (d771980).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ffvalidate/activity.go 92.77% 4 Missing and 2 partials ⚠️
ffvalidate/siegfried_embed.go 87.80% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   81.88%   83.92%   +2.04%     
==========================================
  Files          16       18       +2     
  Lines         436      560     +124     
==========================================
+ Hits          357      470     +113     
- Misses         55       63       +8     
- Partials       24       27       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz requested a review from jraddaoui November 1, 2024 22:03
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @djjuhasz! Just missing an entry in the main readme file.

Add an ffvalidate activity which reads a directory of files, identifies
the file formats using Siegfried [1], and checks the file formats
against the configured CSV list of allowed file formats.

[1] => https://github.com/richardlehane/siegfried
@djjuhasz djjuhasz force-pushed the dev/add-file-format-validate branch from 976079f to d771980 Compare November 5, 2024 00:24
@djjuhasz djjuhasz merged commit bc4a9d8 into main Nov 5, 2024
7 checks passed
@djjuhasz djjuhasz deleted the dev/add-file-format-validate branch November 5, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants