Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Relate preprocessing and AIS workflows #99

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jraddaoui
Copy link
Contributor

Related to artefactual-sdps/enduro#1087 and artefactual-sdps/enduro#886.

  • Generate a UUID in the preprocessing workflow and add it to the result.
  • Receive preprocessing UUID in AIS workflow.
  • TODO:
    • Preprocessing: send metadata file to AIS bucket.
    • AIS: fetch metadata file from AIS bucket.
    • AIS: remove METS parsing code.
    • AIS: remove metadata file download from AMSS.
    • AIS: remove metadata file from AIS bucket when the bundle has been stored.

Generate a UUID in the preprocessing workflow and add it to the result.
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.29%. Comparing base (b5a1f33) to head (7de5cdb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/workflow/preprocessing.go 62.50% 2 Missing and 1 partial ⚠️
cmd/worker/workercmd/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   60.12%   61.29%   +1.17%     
==========================================
  Files          29       33       +4     
  Lines        1996     2186     +190     
==========================================
+ Hits         1200     1340     +140     
- Misses        702      744      +42     
- Partials       94      102       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

func GenUUID(ctx temporalsdk_workflow.Context) (uuid.UUID, error) {
var id uuid.UUID
gen := func(ctx temporalsdk_workflow.Context) interface{} { return uuid.New() }
enc := temporalsdk_workflow.SideEffect(ctx, gen)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, temporalio/sdk-go#916. That's why I went with an UUID generator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the WorkflowID from the processing Workflow? You'd have to pass it to preprocessing and postprocessing too, but it's a unique identifier that is tied to the Workflow execution, and you can set it in test as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants