Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more checksum algorithms (#88) #89

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

mcantelon
Copy link
Contributor

@mcantelon mcantelon commented Nov 25, 2024

Added support for SHA-1, SHA-256, and SHA-512 file checksums.

Refs #88.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (8893cde) to head (4ac122f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/activities/verify_manifest.go 82.14% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   60.20%   60.36%   +0.15%     
==========================================
  Files          29       29              
  Lines        1985     1993       +8     
==========================================
+ Hits         1195     1203       +8     
  Misses        696      696              
  Partials       94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcantelon mcantelon marked this pull request as draft November 25, 2024 09:26
@mcantelon mcantelon changed the title Support more checksum algorithms (#88) WIP: Support more checksum algorithms (#88) Nov 25, 2024
Added support for SHA-1, SHA-256, and SHA-512 file checksums.
@mcantelon mcantelon force-pushed the dev/checksum-formats branch from cc1c537 to 4ac122f Compare November 26, 2024 11:43
@mcantelon mcantelon changed the title WIP: Support more checksum algorithms (#88) Support more checksum algorithms (#88) Nov 26, 2024
@mcantelon mcantelon marked this pull request as ready for review November 26, 2024 11:55
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @mcantelon!

@jraddaoui jraddaoui merged commit 4ac122f into main Nov 26, 2024
9 checks passed
@jraddaoui jraddaoui deleted the dev/checksum-formats branch November 26, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants