Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PREMIS creation preservation task (#73) #85

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mcantelon
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.61%. Comparing base (48f1181) to head (28a42bb).

Files with missing lines Patch % Lines
internal/workflow/preprocessing.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   61.56%   61.61%   +0.05%     
==========================================
  Files          31       31              
  Lines        2084     2087       +3     
==========================================
+ Hits         1283     1286       +3     
+ Misses        705      704       -1     
- Partials       96       97       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcantelon mcantelon force-pushed the dev/premis-write-pres-task branch from 28a42bb to 8a476d5 Compare November 17, 2024 05:31
@mcantelon mcantelon force-pushed the dev/premis-write-pres-task branch from 8a476d5 to 47dab5f Compare November 17, 2024 05:32
@djjuhasz djjuhasz self-requested a review November 18, 2024 15:49
Copy link
Contributor

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcantelon, LGTM! :)

Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mcantelon mcantelon merged commit b516079 into main Nov 18, 2024
7 checks passed
@mcantelon mcantelon deleted the dev/premis-write-pres-task branch November 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants