Use xmlvalidate to validate SIP manifests #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjuhasz
force-pushed
the
dev/issue-39-use-xmlvalidate-activity
branch
from
097b581 to
1aa1951
Compare
djjuhasz
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 53.59% 54.06% +0.47%
==========================================
Files 30 29 -1
Lines 2103 2090 -13
==========================================
+ Hits 1127 1130 +3
+ Misses 907 891 -16
Partials 69 69 ☔ View full report in Codecov by Sentry. |
djjuhasz
force-pushed
the
dev/issue-39-use-xmlvalidate-activity
branch
3 times, most recently
from
af248d5 to
11e9c98
Compare
- Install libxml2-utils in the preprocessing-worker Docker image to provide xmllint, which is required by https://github.com/artefactual-sdps/temporal-activities/tree/main/xmlvalidate - Update Python version 3.13 - Download and build the latest development version of bagit-python to to get the fixes made since the v1.8.1 release, and for compatibility with Python 3.13 - Update the Dockerfile syntax version to the latest version of 1.x - Add stdout & stderr output to error message when running the Python metadata validation script (`xsdval.py`) to aid debugging
djjuhasz
force-pushed
the
dev/issue-39-use-xmlvalidate-activity
branch
from
11e9c98 to
3ad31d4
Compare
Fixes #39 Switch from the internal `ValidateMetadata` activity which calls a Python (xsdval.py) script to the `temporal-activities/xmlvalidate` activity. xmlvalidate calls the xmllint C program to validate the SIP manifest file against the XSD schema files included in the SIP. - Import github.com/artefactual-sdps/temporal-activities/xmlvalidate - Switch to xmlvalidate with the xmllint validator for validating the SIP metadata file - Remove the internal "validate metadata" activivity - Remove the sampledata directory containing the `xsdval.py` script, Arelda XSD files, and sample SIP - Remove Python, python-bagit and lxml from the Docker image
djjuhasz
force-pushed
the
dev/issue-39-use-xmlvalidate-activity
branch
from
3ad31d4 to
919f17f
Compare
jraddaoui
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
Switch from the internal "validate metadata" activity which calls a
Python (xsdval.py) script to the
temporal-activities/xmlvalidatemodule. xmlvalidate calls the xmllint C program to validate the SIP
manifest file against the XSD schema files included in the SIP.
SIP metadata file
xsdval.pyscript,Arelda XSD files, and sample SIP