Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine PREMIS files from Vecteur AIPs #6

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

mcantelon
Copy link
Contributor

No description provided.

@mcantelon mcantelon marked this pull request as draft May 14, 2024 07:36
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 6.89655% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 24.83%. Comparing base (95b103e) to head (94e7871).

Current head 94e7871 differs from pull request most recent head 0ce0188

Please upload reports for the commit 0ce0188 to get more accurate results.

Files Patch % Lines
internal/activities/combine_premis.go 0.00% 71 Missing ⚠️
cmd/worker/workercmd/cmd.go 0.00% 4 Missing ⚠️
internal/activities/transform_vecteur_aip.go 0.00% 4 Missing ⚠️
internal/workflow/preprocessing.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   27.79%   24.83%   -2.97%     
==========================================
  Files          15       16       +1     
  Lines         518      604      +86     
==========================================
+ Hits          144      150       +6     
- Misses        355      434      +79     
- Partials       19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcantelon mcantelon changed the title WIP WIP: combine PREMIS files May 14, 2024
@mcantelon mcantelon changed the title WIP: combine PREMIS files WIP: Combine PREMIS files May 14, 2024
@mcantelon mcantelon force-pushed the dev/combine-premis branch from 3148fff to de9647e Compare May 14, 2024 08:06
@mcantelon mcantelon force-pushed the dev/combine-premis branch 22 times, most recently from e2ba99f to b89f980 Compare May 16, 2024 23:41
@jraddaoui jraddaoui force-pushed the dev/combine-premis branch from e41ab6d to 94e7871 Compare May 17, 2024 12:30
@jraddaoui jraddaoui changed the title WIP: Combine PREMIS files Combine PREMIS files from Vecteur AIPs May 17, 2024
@jraddaoui jraddaoui marked this pull request as ready for review May 17, 2024 12:30
@jraddaoui jraddaoui force-pushed the dev/combine-premis branch from 94e7871 to 0ce0188 Compare May 17, 2024 12:32
@jraddaoui jraddaoui merged commit 0ce0188 into main May 17, 2024
7 checks passed
@jraddaoui jraddaoui deleted the dev/combine-premis branch May 17, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants