Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix born digital SIP PREMIS event recording (#19) #49

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mcantelon
Copy link
Contributor

@mcantelon mcantelon commented Aug 28, 2024

Added support for born digital SIPs to PREMIS event recording.

@mcantelon mcantelon marked this pull request as draft August 28, 2024 03:47
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.37%. Comparing base (8d85bf8) to head (a4c9856).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8d85bf8) and HEAD (a4c9856). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8d85bf8) HEAD (a4c9856)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #49       +/-   ##
===========================================
- Coverage   67.53%   48.37%   -19.17%     
===========================================
  Files          20       26        +6     
  Lines        1072     1505      +433     
===========================================
+ Hits          724      728        +4     
- Misses        285      714      +429     
  Partials       63       63               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcantelon mcantelon force-pushed the dev/premis-fix-for-sips branch 2 times, most recently from e45dc82 to 07341b3 Compare August 28, 2024 05:50
@mcantelon mcantelon changed the title WIP: Dev/premis fix for sips Fix born digital SIP PREMIS event recording (#19) Aug 28, 2024
@mcantelon mcantelon force-pushed the dev/premis-fix-for-sips branch 2 times, most recently from a4c9856 to 2eb4b55 Compare August 28, 2024 07:11
Added support for born digital SIPs to PREMIS event recording.

[skip-codecov]
@mcantelon mcantelon force-pushed the dev/premis-fix-for-sips branch from 2eb4b55 to be1da1b Compare August 28, 2024 07:12
@mcantelon mcantelon marked this pull request as ready for review August 28, 2024 07:14
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcantelon!

@jraddaoui jraddaoui merged commit be1da1b into main Aug 28, 2024
7 checks passed
@jraddaoui jraddaoui deleted the dev/premis-fix-for-sips branch August 28, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants