Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extract package activity #4

Merged
merged 1 commit into from
May 13, 2024
Merged

Remove extract package activity #4

merged 1 commit into from
May 13, 2024

Conversation

jraddaoui
Copy link
Contributor

Expect an extracted SIP from Enduro.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.90%. Comparing base (3102611) to head (d166ff0).

❗ Current head d166ff0 differs from pull request most recent head 21ef7eb. Consider uploading reports for the commit 21ef7eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   27.49%   25.90%   -1.59%     
==========================================
  Files          13       12       -1     
  Lines         451      413      -38     
==========================================
- Hits          124      107      -17     
+ Misses        305      292      -13     
+ Partials       22       14       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Expect an extracted SIP from Enduro.

[skip-codecov]
@jraddaoui jraddaoui merged commit 21ef7eb into main May 13, 2024
7 checks passed
@jraddaoui jraddaoui deleted the dev/no-extract branch May 13, 2024 09:50
@jraddaoui
Copy link
Contributor Author

@mcantelon when you rebase this changes, make sure to set extract to false in the Enduro configuration for the preprocessing child workflow.

@@ -38,7 +38,7 @@ The preprocessing section for Enduro's configuration:
```toml
[preprocessing]
enabled = true
extract = true
extract = false
Copy link
Contributor Author

@jraddaoui jraddaoui May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcantelon, like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @jraddaoui !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants