Switch to a debian-slim base image #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bagit-gython` library requires a system based on `glibc` while Alpine uses `musl`. Change installation of JRE as the one from the veraPDF CLI image is also based on `musl`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 61.48% 61.48%
=======================================
Files 35 35
Lines 2376 2376
=======================================
Hits 1461 1461
Misses 797 797
Partials 118 118 ☔ View full report in Codecov by Sentry. |
|
I tried using a distroless image for consistency with Enduro, but we run veraPDF through a shell script. We could try a Java based distroless image, calling veraPDF with |
djjuhasz
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bagit-gythonlibrary requires a system based onglibcwhileAlpine uses
musl. Change installation of JRE as the one from theveraPDF CLI image is also based on
musl.