Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logical metadata file validation, fixes #98 #101

Merged
merged 3 commits into from
Dec 18, 2024

Move logical metadata file when transforming SIP

3d770f1
Select commit
Loading
Failed to load commit list.
Merged

Add logical metadata file validation, fixes #98 #101

Move logical metadata file when transforming SIP
3d770f1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 1s

61.86% (+0.64%) compared to b0ec45d

View this Pull Request on Codecov

61.86% (+0.64%) compared to b0ec45d

Details

Codecov Report

Attention: Patch coverage is 77.88462% with 23 lines in your changes missing coverage. Please review.

Project coverage is 61.86%. Comparing base (b0ec45d) to head (3d770f1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/activities/validate_premis.go 73.91% 8 Missing and 4 partials ⚠️
cmd/worker/workercmd/cmd.go 0.00% 4 Missing ⚠️
internal/workflow/preprocessing.go 81.81% 3 Missing and 1 partial ⚠️
internal/activities/transform_sip.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   61.22%   61.86%   +0.64%     
==========================================
  Files          32       35       +3     
  Lines        2174     2347     +173     
==========================================
+ Hits         1331     1452     +121     
- Misses        742      780      +38     
- Partials      101      115      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov