Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration validation #10

Merged
merged 1 commit into from
May 28, 2024
Merged

Add configuration validation #10

merged 1 commit into from
May 28, 2024

Conversation

jraddaoui
Copy link
Contributor

  • Verify that required fields have values
  • Verify that MaxConcurrentSessions > 0
  • Add comments describing config fields
  • Add tests for invalid configuration

- Verify that required fields have values
- Verify that MaxConcurrentSessions > 0
- Add comments describing config fields
- Add tests for invalid configuration
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 27.59%. Comparing base (e966ea2) to head (0225937).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/config/config.go 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   24.67%   27.59%   +2.92%     
==========================================
  Files          16       16              
  Lines         608      627      +19     
==========================================
+ Hits          150      173      +23     
+ Misses        438      436       -2     
+ Partials       20       18       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jraddaoui jraddaoui merged commit 0225937 into main May 28, 2024
9 checks passed
@jraddaoui jraddaoui deleted the dev/add-config-validation branch May 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants