-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: make allow file format lists configurable #60
Comments
@sallain I moved this issue from the https://github.com/artefactual-sdps/temporal-activities repository because the "validate-file-format" activity is currently local to preprocessing-sfa. I do think we should move "validate-file-format" to the "temporal-activities" repo so it can be used in other Temporal projects, but it will be easier to do the configuration development here and then move the activity afterwards. |
@sallain we currently only have an "allowed file format" list — any format that is not on the list is disallowed. Should I add the ability to have a "disallowed file format" list as well? If we do add the disallow list, what should happen if a format is not on either list? |
Thank you @djjuhasz! No need for a disallow list at this time - I'll edit the issue. My bad. |
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
Fixes #60 - Add a "fileFormat" section to the preprocessing config file - Add a "AllowlistPath" config option to the "fileFormat" section - If no "AllowlistPath" is configured, then file format validation will be skipped - Add an allowed format CSV file to the dev and enduro kube configs
@scollazo tested this with the following note: "I tested by removing Jp2000 from the list of allowed formats, launching a sip (it fails with the proper error/path), updating the list again, launching the same sip, and it works. no restart needed!" |
Is your feature request related to a problem? Please describe.
The allow file format list is currently hardcoded. Anyone who wants to use this feature will have their own list of allowed formats, so they would have to change the code to suit their requirements. This also puts the list at risk during upgrades/redeployments as it may be reset to the hardcoded default.
Describe the solution you'd like
Make the allow file format list configurable.
In a short discussion with @djjuhasz, he suggested we could either use the enduro.toml config file, or by adding dedicated config files - with a dedicated config file, we could use CSVs instead of TOML, which would be more user-friendly. Open to any option, however!
Describe alternatives you've considered
Keep it as is and cry every time a user forgets to reset their list.
Additional context
The text was updated successfully, but these errors were encountered: