Make logic a one liner

artefactual-sdps · Jun 26, 2024 · bf3aac0 · bf3aac0
1 parent 333a5eb
commit bf3aac0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/internal/activities/add_premis_objects.go b/internal/activities/add_premis_objects.go
@@ -41,12 +41,12 @@ func (md *AddPREMISObjectsActivity) Execute(
 		return nil, err
 	}
 
-	for _, subpath := range subpaths {
-		doc, err := premis.ParseOrInitialize(params.PREMISFilePath)
-		if err != nil {
-			return nil, err
-		}
+	doc, err := premis.ParseOrInitialize(params.PREMISFilePath)
+	if err != nil {
+		return nil, err
+	}
 
+	for _, subpath := range subpaths {
 		object := premis.Object{
 			IdType:       "UUID",
 			IdValue:      uuid.New().String(),
@@ -57,11 +57,11 @@ func (md *AddPREMISObjectsActivity) Execute(
 		if err != nil {
 			return nil, err
 		}
+	}
 
-		err = doc.WriteToFile(params.PREMISFilePath)
-		if err != nil {
-			return nil, err
-		}
+	err = doc.WriteToFile(params.PREMISFilePath)
+	if err != nil {
+		return nil, err
 	}
 
 	return &AddPREMISObjectsResult{}, nil

diff --git a/internal/activities/validate_file_formats.go b/internal/activities/validate_file_formats.go
@@ -94,10 +94,7 @@ func (a *ValidateFileFormats) Execute(
 			detail = fmt.Sprintf("file format %q not allowed: %q", ff.ID, p)
 			outcome = "invalid"
 
-			failures = append(
-				failures,
-				detail,
-			)
+			failures = append(failures, detail)
 		}
 
 		// Define PREMIS event.