Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preservation action started at time #994

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

jraddaoui
Copy link
Collaborator

Mark sql.NullTime as valid before sending to persistence.

Refs #980.

Mark `sql.NullTime` as valid before sending to persistence.
@jraddaoui jraddaoui requested a review from mcantelon July 15, 2024 16:08
@jraddaoui jraddaoui self-assigned this Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (6edaed7) to head (8a76f5a).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   53.06%   53.34%   +0.28%     
==========================================
  Files         101      101              
  Lines        5661     5663       +2     
==========================================
+ Hits         3004     3021      +17     
+ Misses       2408     2395      -13     
+ Partials      249      247       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcantelon
Copy link
Contributor

Looks good to me!

Copy link
Contributor

@mcantelon mcantelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jraddaoui jraddaoui merged commit 8a76f5a into main Jul 15, 2024
15 checks passed
@jraddaoui jraddaoui deleted the dev/issue-980-pres-act-start-time branch July 15, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants